Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-65315: SubmoduleOption: resolve env vars in reference path #1556

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lmife
Copy link

@lmife lmife commented Feb 23, 2024

JENKINS-65315 - Resolve environment variables in SubmoduleOption reference path

On contrary to Freestyle projects' getEnvironment, WorkflowRun.getEnvironment doesn't provide node-specific environment variables as it can have multiple node blocks in parallel. So I suggest to pick up envvars just in place.

See also #575 where this had already been done for CloneOption

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • Unit tests pass locally with my changes
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

On contrary to Freestyle projects' getEnvironment, WorkflowRun.getEnvironment doesn't provide node-specific environment variables as it can have multiple node blocks in parallel. So I suggest to pick up envvars just in place.

See also jenkinsci#575
@lmife lmife requested a review from a team as a code owner February 23, 2024 07:37
@lmife
Copy link
Author

lmife commented Feb 23, 2024

Tests are failing, but I don't know what to do about the "Jenkins.instance is missing. Read the documentation of Jenkins.getInstanceOrNull to see what you are doing wrong.". Even after reading the documentation of Jenkins.getInstanceOrNull I have no clue. If somebody can point me to the right direction this would be very helpful.

Copy link

@milan-deori milan-deori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not good

@lmife
Copy link
Author

lmife commented Apr 15, 2024

not good

can you please give a more in depth explanation? Is the change not working for you?

@lmife
Copy link
Author

lmife commented Jul 4, 2024

Unfortunately, some tests are still failing after merging the latest master into my branch. I still do not understand what the system is trying to tell me and how to fix the issues.
Can anybody assist me here and point me to the right direction? It would be very much appreciated.

@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants