Move testDoNotifyCommitWithInvalidApiToken and use JenkinsRule #1621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move testDoNotifyCommitWithInvalidApiToken and use JenkinsRule
The GitStepTest already includes logic that uses notifyCommit to start jobs and perform other tests of notifyCommit. Use that logic to replace the mocked testDoNotifyCommitWithInvalidApiToken with a test that uses web requests to a JenkinsRule based test.
Prepare for Jetty 12 EE 9 transition.
Also removes unused GitSCMTest methods that were detected while reading the code.
Testing done
Confirmed that tests pass on my Linux computer with Java 21.
Submitter checklist