Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null check condition in PipelineHookTriggerHandlerImpl.java #1613

Merged
merged 4 commits into from
Jan 14, 2024

Conversation

shivajee98
Copy link
Contributor

Fix null check condition in PipelineHookTriggerHandlerImpl.java

The condition hook.getRepository() == null || hook.getRepository() == null is redundant.
This commit removes the duplicate check, leaving only hook.getRepository() == null.
This fix ensures correct null checking for the getRepository() method in PipelineHookTriggerHandlerImpl.java.

@shivajee98 shivajee98 requested a review from a team as a code owner January 13, 2024 21:02
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice find.

@MarkEWaite MarkEWaite merged commit 1fe5d4a into jenkinsci:master Jan 14, 2024
17 checks passed
@krisstern krisstern changed the title Feature branchFix null check condition in PipelineHookTriggerHandlerImpl.java Fix null check condition in PipelineHookTriggerHandlerImpl.java Jan 14, 2024
@krisstern krisstern added the bug For changelog: Minor bug. Will be listed after features label Jan 14, 2024
AniketNS added a commit to AniketNS/gitlab-plugin that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For changelog: Minor bug. Will be listed after features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants