Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in FIPS mode password must have minimum length of 14 characters, this is preparing for upgrade of credentials plugin version #58

Merged
merged 5 commits into from
Sep 18, 2024
Merged

in FIPS mode password must have minimum length of 14 characters, this is preparing for upgrade of credentials plugin version #58

merged 5 commits into from
Sep 18, 2024

Conversation

olamy
Copy link
Member

@olamy olamy commented Sep 16, 2024

Signed-off-by: Olivier Lamy olamy@apache.org

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@olamy
in FIPS mode password must have minimum length of 14 characters, this…
b7383a1 
… is preparing for ugrade of credentials plugin version

Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
olamy commented Sep 16, 2024
View reviewed changes
...jenkinsci/plugins/kubernetes/credentials/AbstractOpenShiftBearerTokenCredentialFIPSTest.java
OpenShiftBearerTokenCredentialImpl cred;
cred = new OpenShiftBearerTokenCredentialImpl(CredentialsScope.GLOBAL, "id", "description", "username", "password");
OpenShiftBearerTokenCredentialImpl cred =
new OpenShiftBearerTokenCredentialImpl(CredentialsScope.GLOBAL, "id", "description", "username", "theaustraliancricketteamisthebest");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of this PR jenkinsci/credentials-plugin#558

@olamy
add doCheckPassword to check minimum lenght in FIPS context
9afbd03 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
better with add the properties file
a342d69 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
Copy link
Member Author

olamy commented Sep 16, 2024

depends on merge of jenkinsci/credentials-plugin#558

@olamy olamy marked this pull request as ready for review September 16, 2024 05:28
@olamy olamy requested a review from a team as a code owner September 16, 2024 05:28
@olamy
adapt to last changes from jenkinsci/credentials-plugin#558
430421d 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use released version of credentials
f574c73 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy changed the title in FIPS mode password must have minimum length of 14 characters, this is preparing for ugrade of credentials plugin version in FIPS mode password must have minimum length of 14 characters, this is preparing for upgrade of credentials plugin version Sep 18, 2024
@olamy olamy merged commit 03c3053 into jenkinsci:master Sep 18, 2024
16 checks passed
@olamy olamy deleted the password-length-fips-mode branch September 18, 2024 05:38
@basil basil mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@olamy