[JENKINS-34808] - Allow user to adjust socket timeout #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
|
the build was aborted for exceeding build time limit (8 minutes), maybe caused by slow maven download. I don't think the commit will affects the build |
| @@ -403,6 +403,8 @@ public static Engine current() { | |||
|
|
|||
| private static final Logger LOGGER = Logger.getLogger(Engine.class.getName()); | |||
|
|
|||
| static final int TIMEOUT = Integer.getInteger(Engine.class.getName()+".soTimeout",30*60*1000); | |||
There was a problem hiding this comment.
Maybe "socketTimeout"? Readability is better than economy on several symbols :)
|
merge conflict |
|
I want to make the timeout configurable before the next version release |
fengxx
force-pushed
the
feature/sotimeout
branch
from
591536a
to
939adb1
Compare
|
Thanks for reviewing, I had renamed it to socketTimeout |
oleg-nenashev
changed the title
|
Subject for a backporting. I'll create an issue |
oleg-nenashev
changed the title
oleg-nenashev
added a commit
to oleg-nenashev/jenkins
that referenced
this pull request
May 13, 2016
Changes: * [JENKINS-34213](https://issues.jenkins-ci.org/browse/JENKINS-34213) - Ensure that the unexporter cleans up whatever it can each sweep (jenkinsci/remoting#81) * [JENKINS-19445](https://issues.jenkins-ci.org/browse/JENKINS-19445) Force class load on UserRequest in order to prevent deadlock on windows nodes when using JNA and Subversion (jenkinsci/remoting#81) * [JENKINS-34808](https://issues.jenkins-ci.org/browse/JENKINS-34808) - Allow user to adjust socket timeout (jenkinsci/remoting#68)
oleg-nenashev
added a commit
to jenkinsci/jenkins
that referenced
this pull request
May 14, 2016
…oting to 2.59. (#2344) * [JENKINS-19445, JENKINS-34213, JENKINS-34808] Bump remoting to 2.58. Changes: * [JENKINS-34213](https://issues.jenkins-ci.org/browse/JENKINS-34213) - Ensure that the unexporter cleans up whatever it can each sweep (jenkinsci/remoting#81) * [JENKINS-19445](https://issues.jenkins-ci.org/browse/JENKINS-19445) Force class load on UserRequest in order to prevent deadlock on windows nodes when using JNA and Subversion (jenkinsci/remoting#81) * [JENKINS-34808](https://issues.jenkins-ci.org/browse/JENKINS-34808) - Allow user to adjust socket timeout (jenkinsci/remoting#68) * [JENKINS-34121] - Upgrade remoting to 2.59
oleg-nenashev
added a commit
to oleg-nenashev/jenkins
that referenced
this pull request
May 17, 2016
…oting to 2.59 Changes: 2.58: * [JENKINS-34213](https://issues.jenkins-ci.org/browse/JENKINS-34213) - Ensure that the unexporter cleans up whatever it can each sweep (jenkinsci/remoting#81) * [JENKINS-19445](https://issues.jenkins-ci.org/browse/JENKINS-19445) Force class load on UserRequest in order to prevent deadlock on windows nodes when using JNA and Subversion (jenkinsci/remoting#82) * [JENKINS-34808](https://issues.jenkins-ci.org/browse/JENKINS-34808) - Allow user to adjust socket timeout (jenkinsci/remoting#68) 2.59: * [JENKINS-34819](https://issues.jenkins-ci.org/browse/JENKINS-34819) - Allow disabling the remoting protocols individually. Works around issues like [JENKINS-34121](https://issues.jenkins-ci.org/browse/JENKINS-34121) (jenkinsci/remoting#83)
olivergondza
pushed a commit
to jenkinsci/jenkins
that referenced
this pull request
May 25, 2016
…oting to 2.59. (#2344) * [JENKINS-19445, JENKINS-34213, JENKINS-34808] Bump remoting to 2.58. Changes: * [JENKINS-34213](https://issues.jenkins-ci.org/browse/JENKINS-34213) - Ensure that the unexporter cleans up whatever it can each sweep (jenkinsci/remoting#81) * [JENKINS-19445](https://issues.jenkins-ci.org/browse/JENKINS-19445) Force class load on UserRequest in order to prevent deadlock on windows nodes when using JNA and Subversion (jenkinsci/remoting#81) * [JENKINS-34808](https://issues.jenkins-ci.org/browse/JENKINS-34808) - Allow user to adjust socket timeout (jenkinsci/remoting#68) * [JENKINS-34121] - Upgrade remoting to 2.59 (cherry picked from commit 409438f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we encounter slave offline issue when executing commands like
sleep 40mon jnlp agent, the socket read timeout is hard coded to 30 minutes and caused the issue