Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Java 11 readiness: build both on JDK8 and JDK11 #44

Closed
wants to merge 2 commits into from

Conversation

batmat
Copy link
Member

@batmat batmat commented Apr 10, 2019

Work in progress to make sure this plugin is constantly checked both building with JDK8 and JDK11.

This goes with the Jenkins Java 11 General Availability announcement made back in March, and we're making a pass to check plugins are looking good on a JDK11.

(to understand the Jenkinsfile content)

@batmat
Copy link
Member Author

batmat commented Apr 16, 2019

FTR, FindBugs issues on newer baseline, even on JDK8.

Also, locally test failures

[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.445 s - in org.jenkinsci.plugins.structs.SymbolLookupTest
[INFO] Running org.jenkinsci.plugins.structs.describable.DescribableModelTest
[ERROR] Tests run: 53, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 9.021 s <<< FAILURE! - in org.jenkinsci.plugins.structs.describable.DescribableModelTest
[ERROR] parametersDefinitionProperty(org.jenkinsci.plugins.structs.describable.DescribableModelTest)  Time elapsed: 0.019 s  <<< FAILURE!
java.lang.AssertionError: expected:<{parameterDefinitions=[{$class=BooleanParameterDefinition, defaultValue=false, name=flag}, {$class=StringParameterDefinition, name=text}]}> but was:<{parameterDefinitions=[{$class=BooleanParameterDefinition, defaultValue=false, name=flag}, {$class=StringParameterDefinition, name=text, trim=false}]}>
        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.failNotEquals(Assert.java:834)
        at org.junit.Assert.assertEquals(Assert.java:118)
        at org.junit.Assert.assertEquals(Assert.java:144)
        at org.jenkinsci.plugins.structs.describable.DescribableModelTest.roundTrip(DescribableModelTest.java:894)
        at org.jenkinsci.plugins.structs.describable.DescribableModelTest.roundTrip(DescribableModelTest.java:885)
        at org.jenkinsci.plugins.structs.describable.DescribableModelTest.parametersDefinitionProperty(DescribableModelTest.java:635)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
        at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
        at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
        at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
        at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
        at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
        at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
        at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:556)
        at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
        at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.lang.Thread.run(Thread.java:748)

@batmat
Copy link
Member Author

batmat commented Jan 27, 2022

Superseded by #121

@batmat batmat closed this Jan 27, 2022
@batmat batmat deleted the java11-readiness branch January 27, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant