Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency resolution #1266

Merged
merged 40 commits into from
May 7, 2018
Merged

Fix dependency resolution #1266

merged 40 commits into from
May 7, 2018

Conversation

jeremylong
Copy link
Owner

Fixes Issue #740

  • Upgrades maven-dependency-tree (this PR supersedes Upgrade maven-dependency-tree version #1165)
  • When analyzing an aggregate build (in Maven) if a child module has not been built and as such, the JAR file does not exist, a warning will be printed and a dependency will be added that contains the evidence from the build - but does not point back to a specific file.
  • Fixed bug that would cause pom.xml dependencies without an identifier to be incorrectly merged with any other JAR.

Have test cases been added to cover the new functionality?

yes

jeremylong and others added 30 commits April 9, 2018 14:03
@jeremylong
upgrade dependency tree version
ab174b4
@jeremylong
update invoker properties
3825a27
@aikebah
Add project to buildingRequest
b41c68b
@jeremylong
Merge pull request #1250 from aikebah/maven-tree-upgrade
c682078 
Add project to buildingRequest
@jeremylong
upgrade dependency tree version
ea0603f
@jeremylong
update invoker properties
7c8dbcc
@jeremylong
added test case
0c0b0e3
@jeremylong
fixed merge conflict
fdd51fe
@jeremylong
fix test case
251aa8f
@jeremylong
update to create virtual dependencies
feb688f
@jeremylong
fix test case
c929220
@jeremylong
removed debug logging
0b84b09
@jeremylong
fix test case
ee3d1e8
@jeremylong
update to create virtual dependencies
5f10ff7
@jeremylong
Merge branch 'non-resolvable-fix' of github.com:jeremylong/Dependency…
ba5e5e7 
…Check into non-resolvable-fix
@jeremylong
add logging output for 740
916ff90
@jeremylong
fix test case
894fc8d
@jeremylong
update test case
9498f2c
@jeremylong
update to create virtual dependencies
86b0ce3
@jeremylong
Merge branch 'non-resolvable-fix' of github.com:jeremylong/Dependency…
5973bc9 
…Check into non-resolvable-fix
@jeremylong
added logging
758ee32
@jeremylong
added logging
ccae164
@jeremylong
added logging
d4b36fa
@jeremylong
fixed bug - not calling scan artifacts indicate the scan is an aggregate
c9929d0
@jeremylong
updated exception handling
46cac41
@jeremylong
fix npe
b4fa608
@jeremylong
manually apply #1260 as rebase is failing
fd07254
@jeremylong
fix postbuild validation of test
df9a3c9
@jeremylong
fix test case
7707c30
@jeremylong
updated logging to debug test in CI
d013ff6
@jeremylong
Copy link
Owner Author

Can one of the admins verify this patch?

@jeremylong jeremylong mentioned this pull request May 7, 2018
Closed
@jeremylong jeremylong merged commit c541850 into master May 7, 2018
@jeremylong jeremylong deleted the non-resolvable-fix branch June 17, 2018 10:50
@lock lock bot locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremylong @aikebah