Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Further improve formatting and docs of H2 database caching strats #6804

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

chadlwilson
Copy link
Contributor

@chadlwilson chadlwilson commented Jul 4, 2024

Description of Change

As discussed at #6758 (comment) use of shared disk storage (e.g network mounts) for collaboration by ODC clients apparently works fine and is supported via filesystem locks.

As such have specifically referred to it in the caching docs and adjusted the wording and formatting.

Easiest to review with the rich diff.

Have test cases been added to cover the new functionality?

N/A

…tegies

Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
@boring-cyborg boring-cyborg bot added the documentation site documentation label Jul 4, 2024
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong
Copy link
Owner

@chadlwilson again - thank you for your contributions. I really appreciate it.

@jeremylong jeremylong merged commit 3bfb398 into jeremylong:main Jul 4, 2024
5 checks passed
@jeremylong jeremylong added this to the 10.0.2 milestone Jul 4, 2024
@chadlwilson chadlwilson deleted the improve-cache-docs branch July 4, 2024 15:08
@chadlwilson
Copy link
Contributor Author

chadlwilson commented Jul 4, 2024

@chadlwilson again - thank you for your contributions. I really appreciate it.

All for the greater good! it's pretty insane that this project is so widely used yet operates in a dominant single contributor mode :-(

@jeremylong
Copy link
Owner

@chadlwilson What people find even more insane - I haven't used dependency-check in 10+ years. I maintain it because people find it useful and I'm doing what I can to help improve security wherever I can. Every company I work for has a commercial product.

@chadlwilson
Copy link
Contributor Author

chadlwilson commented Jul 5, 2024

@jeremylong sounds familiar! While I was not the creator like you are for ODC, that's a similar story to me maintaining https://github com/gocd/gocd (less actively than yourself, and not anywhere near as widely used) for the last 3 years - despite not using it day to day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation site documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants