Add navigation with numbers #540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemxm
added a commit
to jorgemxm/lazydocker
that referenced
this pull request
Jun 12, 2024
PR - jesseduffield#540 - Fix jesseduffield#522 - Like lazygit we can navigate with numbers. - jesseduffield/lazydocker@master...peauc:lazydocker:feature/issue-522-add-number-like-lazygit
jesseduffield
requested changes
Jul 21, 2024
pkg/i18n/english.go
Outdated
| FocusContainers string | ||
| FocusImages string | ||
| FocusVolumes string | ||
| FocusNetwork string |
There was a problem hiding this comment.
Suggested change
| FocusNetwork string | |
| FocusNetworks string |
Should be plural for consistency
There was a problem hiding this comment.
@jesseduffield changes have been made :)
|
Looks good @peauc. Can you squash your commits down to one? |
|
@jesseduffield of course, I do not mind. |
peauc
force-pushed
the
feature/issue-522-add-number-like-lazygit
branch
from
7ead397
to
1dc8033
Compare
A la lazygit, we can now navigate between panels using numbers (1,2,3,4,5,6,7) Add translation for number navigation reformat oops fix translation case & generate docs pluralize networks
peauc
force-pushed
the
feature/issue-522-add-number-like-lazygit
branch
from
1dc8033
to
86cce84
Compare
|
alright its done :) @jesseduffield |
jorgemxm
added a commit
to jorgemxm/lazydocker
that referenced
this pull request
Jul 27, 2024
PR - jesseduffield#540 - Fix jesseduffield#522 - Like lazygit we can navigate with numbers. - jesseduffield/lazydocker@master...peauc:lazydocker:feature/issue-522-add-number-like-lazygit
|
Small nudge @jesseduffield |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #522
Like lazygit we can navigate with numbers.