Reapply "Check for fixup commits on CI" #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f2db9fa.
stefanhaller
added
the
maintenance
stefanhaller
force-pushed
the
check-for-fixup-commits-on-ci
branch
from
4564b37
to
76ba2f4
Compare
My local git is not compiled with PCRE support, so using -E makes it easier for me to test the script locally. And -E is good enough for the simple matching we want to do here.
stefanhaller
force-pushed
the
check-for-fixup-commits-on-ci
branch
2 times, most recently
from
983c0b5
to
8c5b669
Compare
Also check for squash! and amend! (these are all anchored to the beginning of the subject), and WIP and DROPME for good measure (but only if they occur in the first line, otherwise it wouldn't let me merge this very commit :)
stefanhaller
force-pushed
the
check-for-fixup-commits-on-ci
branch
from
8c5b669
to
20ccb03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable the check for fixup commits (see #3742), make it work for forks, and extend it to "amend!" and "WIP" commits (and a few others).