chore: enforce curly braces (#1429)

* chore: enforce curly braces * refactor: apply eslint fixes
jest-community · Sep 8, 2023 · eeafcc9 · eeafcc9
1 parent e44693f
commit eeafcc9
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 7 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -84,6 +84,7 @@ module.exports = {
     'prefer-rest-params': 'error',
     'prefer-const': ['error', { destructuring: 'all' }],
     'no-var': 'error',
+    curly: 'error',
   },
   overrides: [
     {

diff --git a/src/rules/expect-expect.ts b/src/rules/expect-expect.ts
@@ -28,7 +28,9 @@ function matchesAssertFunctionName(
       `^${p
         .split('.')
         .map(x => {
-          if (x === '**') return '[a-z\\d\\.]*';
+          if (x === '**') {
+            return '[a-z\\d\\.]*';
+          }
 
           return x.replace(/\*/gu, '[a-z\\d]*');
         })

diff --git a/src/rules/no-test-return-statement.ts b/src/rules/no-test-return-statement.ts
@@ -47,7 +47,9 @@ export default createRule({
           t => t.type === AST_NODE_TYPES.ReturnStatement,
         );
 
-        if (!returnStmt) return;
+        if (!returnStmt) {
+          return;
+        }
 
         context.report({ messageId: 'noReturnValue', node: returnStmt });
       },
@@ -58,13 +60,17 @@ export default createRule({
           context,
         );
 
-        if (testCallExpressions.length === 0) return;
+        if (testCallExpressions.length === 0) {
+          return;
+        }
 
         const returnStmt = node.body.body.find(
           t => t.type === AST_NODE_TYPES.ReturnStatement,
         );
 
-        if (!returnStmt) return;
+        if (!returnStmt) {
+          return;
+        }
 
         context.report({ messageId: 'noReturnValue', node: returnStmt });
       },

diff --git a/src/rules/no-untyped-mock-factory.ts b/src/rules/no-untyped-mock-factory.ts
@@ -70,7 +70,9 @@ export default createRule({
             data: { moduleName: moduleName?.raw ?? './module-name' },
             node,
             fix(fixer) {
-              if (!moduleName) return [];
+              if (!moduleName) {
+                return [];
+              }
 
               return [
                 fixer.insertTextAfter(

diff --git a/src/rules/prefer-spy-on.ts b/src/rules/prefer-spy-on.ts
@@ -85,11 +85,15 @@ export default createRule({
       AssignmentExpression(node) {
         const { left, right } = node;
 
-        if (left.type !== AST_NODE_TYPES.MemberExpression) return;
+        if (left.type !== AST_NODE_TYPES.MemberExpression) {
+          return;
+        }
 
         const jestFnCall = getJestFnCall(right);
 
-        if (!jestFnCall) return;
+        if (!jestFnCall) {
+          return;
+        }
 
         context.report({
           node,