-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect open handles with done callbacks #11382
Merged
SimenB
merged 13 commits into
jestjs:master
from
Mr0grog:detect-open-handles-with-done-callbacks
May 20, 2021
Merged
Detect open handles with done callbacks #11382
SimenB
merged 13 commits into
jestjs:master
from
Mr0grog:detect-open-handles-with-done-callbacks
May 20, 2021
Commits on May 6, 2021
-
Add failing tests for open handles with
done
This adds a unit test and two new integration tests to assert that hanging async handles created in test or lifecycle functions with `done` callbacks are correctly detected and logged when using `--detectOpenHandles`. They all fail when used with the Jasmine runner right now (things work fine with Circus; yay!).
Configuration menu - View commit details
-
Copy full SHA for 8c6276d - Browse repository at this point
Copy the full SHA 8c6276dView commit details
Commits on May 7, 2021
-
Wrap functions w/ a callback in a named function
Wrap test and lifecycle functions that take a `done` callback in a named function so that they can be detected as user code in the call stack. This lets the `collectHandles` module in jest-core know to track async resources created in those functions. Fixes jestjs#11377.
Configuration menu - View commit details
-
Copy full SHA for 125d47b - Browse repository at this point
Copy the full SHA 125d47bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 799399e - Browse repository at this point
Copy the full SHA 799399eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d47be8 - Browse repository at this point
Copy the full SHA 6d47be8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 944f969 - Browse repository at this point
Copy the full SHA 944f969View commit details -
Configuration menu - View commit details
-
Copy full SHA for bdb38fd - Browse repository at this point
Copy the full SHA bdb38fdView commit details
Commits on May 8, 2021
-
Update packages/jest-jasmine2/src/jasmineAsyncInstall.ts
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2088443 - Browse repository at this point
Copy the full SHA 2088443View commit details -
Update packages/jest-jasmine2/src/jasmineAsyncInstall.ts
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2adf035 - Browse repository at this point
Copy the full SHA 2adf035View commit details
Commits on May 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ca185ca - Browse repository at this point
Copy the full SHA ca185caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 439018f - Browse repository at this point
Copy the full SHA 439018fView commit details
Commits on May 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b144f11 - Browse repository at this point
Copy the full SHA b144f11View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6eb3969 - Browse repository at this point
Copy the full SHA 6eb3969View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4803a6c - Browse repository at this point
Copy the full SHA 4803a6cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.