Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(babel-jest): add option excludeJestPreset #15164

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

latin-1
Copy link
Contributor

@latin-1 latin-1 commented Jul 4, 2024

Summary

Add option jestPreset to allow opting out of babel-preset-jest.

Fixes #15155

Test plan

Copy link

netlify bot commented Jul 4, 2024

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3204077
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6688172506de240008bccd12
😎 Deploy Preview https://deploy-preview-15164--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@latin-1 latin-1 force-pushed the babel-jest-add-option-jest-preset branch 2 times, most recently from f60cde8 to d477044 Compare July 4, 2024 17:49
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Could you also add some tests and docs?

Probably mention in https://jestjs.io/docs/code-transformation#defaults

packages/babel-jest/src/index.ts Outdated Show resolved Hide resolved
@latin-1 latin-1 force-pushed the babel-jest-add-option-jest-preset branch from d477044 to 9f957f0 Compare July 5, 2024 15:41
@latin-1
Copy link
Contributor Author

latin-1 commented Jul 5, 2024

@SimenB option renamed & tests/docs added

@latin-1 latin-1 force-pushed the babel-jest-add-option-jest-preset branch from 9f957f0 to fb06df7 Compare July 5, 2024 15:44
@latin-1 latin-1 requested a review from SimenB July 5, 2024 15:44
@latin-1 latin-1 changed the title feat(babel-jest): add option jestPreset feat(babel-jest): add option excludeJestPreset Jul 5, 2024
@latin-1 latin-1 force-pushed the babel-jest-add-option-jest-preset branch from fb06df7 to 3204077 Compare July 5, 2024 15:54
@SimenB
Copy link
Member

SimenB commented Jul 5, 2024

Thanks!

@SimenB SimenB merged commit 1775865 into jestjs:main Jul 5, 2024
83 of 84 checks passed
@latin-1 latin-1 deleted the babel-jest-add-option-jest-preset branch July 5, 2024 17:23
Copy link

github-actions bot commented Aug 7, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: babel-jest: opting out babel-preset-jest
2 participants