Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to react-native@0.61 in examples #8884

Merged
merged 6 commits into from
Feb 11, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 28, 2019

Summary

In an effort to make #8535 smaller. Upgrading to 0.59 worked fine, but 0.60 gives Cannot find module 'StyleSheet' from 'react-native-implementation.js'. Ideas? Can just 0.59 I guess, but seems silly.

Test plan

Green CI?

@jrwpatterson
Copy link

did you find a fix for this... I have the same problem bringing these in.

@SimenB
Copy link
Member Author

SimenB commented Jan 28, 2020

I get

    TypeError: Cannot read property 'getItem' of undefined

      at FlatList._checkProps (../../node_modules/react-native/Libraries/Lists/FlatList.js:672:1540)

when I run from root, but it works if I run it from the example directory... No idea what's up

@SimenB SimenB changed the title Bump version of RN in example chore: bump to react-native@0.61 in examples Feb 11, 2020
@drew-gross
Copy link

Codecov Report

Merging #8884 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8884   +/-   ##
=======================================
  Coverage   65.04%   65.04%           
=======================================
  Files         286      286           
  Lines       12123    12123           
  Branches     3004     3004           
=======================================
  Hits         7885     7885           
  Misses       3600     3600           
  Partials      638      638           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47b8aae...aac7a62. Read the comment docs.

@SimenB SimenB merged commit b3bfc33 into jestjs:master Feb 11, 2020
@SimenB SimenB deleted the rn-example-bump branch February 11, 2020 18:18
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants