Add content-type header to responses

jgoz · Jul 4, 2023 · 2a7f404 · 2a7f404
1 parent 326fb81
commit 2a7f404
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 16 deletions.
diff --git a/.changeset/six-birds-tell.md b/.changeset/six-birds-tell.md
@@ -0,0 +1,5 @@
+---
+'esbd': patch
+---
+
+Add Content-Type header to static responses
diff --git a/packages/esbd/package.json b/packages/esbd/package.json
@@ -29,7 +29,7 @@
   "devDependencies": {
     "@playwright/test": "^1.35.1",
     "@types/pretty-time": "^1.1.2",
-    "@types/serve-static": "^1.15.2",
+    "@types/serve-static": "~1.13.0",
     "@types/wait-on": "^5.3.1",
     "cleye": "^1.3.2",
     "esbuild": "^0.18.11",

diff --git a/packages/esbd/src/esbd-serve.ts b/packages/esbd/src/esbd-serve.ts
@@ -174,8 +174,17 @@ export default async function esbdServe(
     },
   });
 
-  const outputHandler = serveStatic(absOutDir, { fallthrough: false });
-  const servedirHandler = servedir ? serveStatic(servedir, { fallthrough: true }) : undefined;
+  const setHeaders: serveStatic.ServeStaticOptions['setHeaders'] = (res, path) => {
+    if (res.hasHeader('content-type')) return;
+
+    const contentType = serveStatic.mime.lookup(path);
+    if (contentType) res.setHeader('content-type', contentType);
+  };
+
+  const outputHandler = serveStatic(absOutDir, { fallthrough: false, setHeaders });
+  const servedirHandler = servedir
+    ? serveStatic(servedir, { fallthrough: true, setHeaders })
+    : undefined;
 
   const staticHandler: ReturnType<typeof serveStatic> = servedirHandler
     ? (req, res, next) => servedirHandler(req, res, () => outputHandler(req, res, next))

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml