Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change/feature Request: Border-radiuses on .field.has-addons #1656

Closed
My1 opened this issue Feb 12, 2018 · 0 comments · Fixed by #2157 or tghelere/valorize-vidas#6 · May be fixed by devopsred/gaia#6, anikets43/angular-ngrx-socket-frontend#4 or jwlh/WDI_GROUP_PROJECT#2

Comments

@My1
Copy link

My1 commented Feb 12, 2018

This is about Bulma.

Overview of the problem

This is about the Bulma CSS framework
I'm using Bulma version 0.6.2
My browser is: Opera
I am sure this issue is not a duplicate

Description

the Field with addons is made in a way that when changing from a multiple elements in the field to a single one requires removing this addon-class as well, otherwise the border-radiuses would be killed, this is because of the following styles:

buttons have by default rounded corners. by inserting them into a field.has-addons the following things are applied:

if it is not the first and not the last child, all radiuses become zero

if it is the first child, the right border-radiuses become zero

if it is the last child, the left border-radiuses become zero.

wouldn't it make more sense to only say:

not first child -> left border-radiuses become zero

not last-child -> right border-radiuses become zero.

therefore:
only-child -> no borders changed
middle-child (not first and not last) -> all border-radiuses become zero

this would not only remove some redundant CSS (not a lot, but whatever) but also make scripting logic a lot easier, because one doesnt have to care, whether the field has just one or multiple children.

Steps to Reproduce

create field.has-addons with only one

Expected behavior

border-radiuses are applied (like with button-groups in bootstrap)

Actual behavior

the border-radiuses are zero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment