Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3383 ('Variables' sections on docs page) #3513

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Conversation

avt613
Copy link
Contributor

@avt613 avt613 commented Apr 26, 2022

This is a documentation fix.

Related to issue #3383

There are 2 Variables sections on the variables page with the same ID's and no gap between them. The right hand menu shows 2 Variable sections which both take you to the first one of the 2 variable sections.

Proposed solution

  1. Give each variables section a different name, by using the anchor_name as the section title
  2. Add gap between consecutive variable 'divs' (identified by class="bd-vars")

Tradeoffs

None that I can see.

Testing Done

Some...
Fixes problem on the variables page, but may cause unintended issues on other pages which use the modified file if they have an anchor_name set which should not be used for the section title.

Changelog updated?

No.

Screenshot

image

@jgthms jgthms merged commit 8f13d7c into jgthms:master Apr 26, 2022
@avt613
Copy link
Contributor Author

avt613 commented Apr 26, 2022

Thanks for merging.
The scss for the Bulma docs has not been recompiled yet.
Is this done automatically or does it need to be done manually? (The other change has already taken affect)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants