Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 4 as dependency #569

Merged
merged 3 commits into from
Mar 9, 2020
Merged

Allow Symfony 4 as dependency #569

merged 3 commits into from
Mar 9, 2020

Conversation

Berdir
Copy link
Contributor

@Berdir Berdir commented Feb 17, 2020

@Berdir
Copy link
Contributor Author

Berdir commented Feb 19, 2020

Not sure what exactly the problem is here. Only thing I found was symfony/symfony#29907, could be a conflict between what is used by drupal and what's added by this, because I think we're not actually installing drupalextension inside drupal and then nothing ensures that version are kept in sync.

@Berdir
Copy link
Contributor Author

Berdir commented Feb 20, 2020

To make this work and install the proper version of things, we might want to use a similar approach as DrupalCI, and add the git checkout of drupalextension as a repository to drupal an then install it from there, that will then respect existing dependencies and pick a compatible version.

@Berdir Berdir mentioned this pull request Feb 22, 2020
@Berdir
Copy link
Contributor Author

Berdir commented Feb 22, 2020

Got it to pass with a workaround and created #570 with ideas on how to improve travis testing.

Copy link
Contributor

@MPParsley MPParsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We also need Symfony 4 support.

$ composer why symfony/browser-kit
behat/mink-browserkit-driver  1.3.3   requires  symfony/browser-kit (~2.3|~3.0|~4.0)  
drupal/drupal-extension       v4.0.1  requires  symfony/browser-kit (^3.4)            
fabpot/goutte                 v3.2.3  requires  symfony/browser-kit (~2.1|~3.0|~4.0)  

@jhedstrom jhedstrom merged commit cbe52c5 into jhedstrom:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants