trace

jimczi · Jul 26, 2018 · 327f1ba · 327f1ba
1 parent 6d25980
commit 327f1ba
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/server/src/main/java/org/elasticsearch/indices/flush/SyncedFlushService.java b/server/src/main/java/org/elasticsearch/indices/flush/SyncedFlushService.java
@@ -397,7 +397,7 @@ public void handleResponse(ShardSyncedFlushResponse response) {
 
                         @Override
                         public void handleException(TransportException exp) {
-                            logger.trace(() -> new ParameterizedMessage("{} error while performing synced flush on [{}], skipping", shardId, shard), exp);
+                            logger.error(() -> new ParameterizedMessage("{} error while performing synced flush on [{}], skipping", shardId, shard), exp);
                             results.put(shard, new ShardSyncedFlushResponse(exp.getMessage()));
                             countDownAndSendResponseIfDone(syncId, shards, shardId, totalShards, listener, countDown, results);
                         }
@@ -474,7 +474,7 @@ private PreSyncedFlushResponse performPreSyncedFlush(PreShardSyncedFlushRequest
         indexShard.flush(flushRequest);
         final CommitStats commitStats = indexShard.commitStats();
         final Engine.CommitId commitId = commitStats.getRawCommitId();
-        logger.trace("{} pre sync flush done. commit id {}, num docs {}", request.shardId(), commitId, commitStats.getNumDocs());
+        logger.error("{} pre sync flush done. commit id {}, num docs {}", request.shardId(), commitId, commitStats.getNumDocs());
         return new PreSyncedFlushResponse(commitId, commitStats.getNumDocs(), commitStats.syncId());
     }
 

diff --git a/server/src/test/java/org/elasticsearch/indices/flush/FlushIT.java b/server/src/test/java/org/elasticsearch/indices/flush/FlushIT.java
@@ -278,8 +278,16 @@ public void testSyncedFlushSkipOutOfSyncReplicas() throws Exception {
                 indexDoc(IndexShardTestCase.getEngine(indexShard), "extra_" + i);
             }
         }
+
         final ShardsSyncedFlushResult fullResult = SyncedFlushUtil.attemptSyncedFlush(logger, internalCluster(), shardId);
+        assertBusy(() -> {
+            for (IndexShard shard : indexShards) {
+                assertThat(shard.routingEntry().toString(),
+                    shard.commitStats().getNumDocs(), equalTo(numDocs + extraDocs));
+            }
+        });
         assertThat(fullResult.totalShards(), equalTo(numberOfReplicas + 1));
+        assertThat(fullResult.failureReason(), nullValue());
         assertThat(fullResult.successfulShards(), equalTo(numberOfReplicas + 1));
     }