Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: does not require port #735

Merged
merged 1 commit into from
May 31, 2022
Merged

fix: does not require port #735

merged 1 commit into from
May 31, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented May 31, 2022

The exposed service from jcloud does not need a port.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #735 (be4dfa5) into main (60a986a) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   80.86%   80.91%   +0.05%     
==========================================
  Files          16       16              
  Lines        1155     1153       -2     
==========================================
- Hits          934      933       -1     
+ Misses        221      220       -1     
Flag Coverage Δ
cas 80.91% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/clip_client/client.py 87.22% <ø> (+0.40%) ⬆️
client/clip_client/__init__.py 100.00% <100.00%> (ø)
server/clip_server/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b523c62...be4dfa5. Read the comment docs.

Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit 751cf9d into main May 31, 2022
@numb3r3 numb3r3 deleted the fix-port branch May 31, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants