Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow test to pass even if commit name is not good #856

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Nov 11, 2022

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #856 (540d98b) into main (7108622) will decrease coverage by 2.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #856      +/-   ##
==========================================
- Coverage   81.39%   79.32%   -2.07%     
==========================================
  Files          21       21              
  Lines        1596     1596              
==========================================
- Hits         1299     1266      -33     
- Misses        297      330      +33     
Flag Coverage Δ
cas 79.32% <ø> (-2.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/model/trt_utils.py 56.04% <0.00%> (-27.48%) ⬇️
server/clip_server/model/clip_trt.py 69.38% <0.00%> (-16.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot added size/s and removed size/xs labels Nov 11, 2022
@jina-ai jina-ai deleted a comment from github-actions bot Nov 11, 2022
@ZiniuYu ZiniuYu requested a review from numb3r3 November 11, 2022 11:16
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZiniuYu ZiniuYu merged commit d2ecec6 into main Nov 14, 2022
@ZiniuYu ZiniuYu deleted the chore-ci-let-test-pass branch November 14, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants