chore: replace clip server address in docs #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemmyshin
requested changes
Nov 11, 2022
| @@ -275,7 +275,7 @@ Then call `rank`, you can feed it with multiple Documents as a list: | |||
| ```python | |||
| from clip_client import Client | |||
|
|
|||
| c = Client(server='grpcs://demo-cas.jina.ai:2096') | |||
| c = Client(server='grpc://0.0.0.0:23456') | |||
There was a problem hiding this comment.
why not grpcs://api.clip.jina.ai:2096 here?
There was a problem hiding this comment.
I don't want to add "token" everywhere
Codecov Report
@@ Coverage Diff @@
## main #857 +/- ##
=======================================
Coverage 81.39% 81.39%
=======================================
Files 21 21
Lines 1596 1596
=======================================
Hits 1299 1299
Misses 297 297
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
numb3r3
requested changes
Nov 11, 2022
docs/user-guides/server.md
Outdated
| @@ -559,7 +559,7 @@ When the server is successfully running, you can connect to it via client by set | |||
| ```python | |||
| from clip_client import Client | |||
|
|
|||
| c = Client('grpcs://demo-cas.jina.ai:2096') | |||
| c = Client('grpcs://api.clip.jina.ai:2096') | |||
There was a problem hiding this comment.
It does not make sense to use our free service API here. Just use a dummy one.
ZiniuYu
force-pushed
the
docs-replace-server-address
branch
from
4497739
to
0642447
Compare
|
📝 Docs are deployed on https://ft-docs-replace-server-address--jina-docs.netlify.app 🎉 |
numb3r3
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace demo-cas.jina.ai everywhere in docs