Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: test no data lock in batch queue #6201

Merged
merged 4 commits into from
Sep 20, 2024
Merged

test: test no data lock in batch queue #6201

merged 4 commits into from
Sep 20, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Sep 18, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels Sep 18, 2024
@JoanFM JoanFM marked this pull request as ready for review September 18, 2024 18:40
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 40.52%. Comparing base (09f61da) to head (fa746ba).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
jina/serve/runtimes/worker/batch_queue.py 0.00% 56 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (09f61da) and HEAD (fa746ba). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (09f61da) HEAD (fa746ba)
jina 12 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6201       +/-   ##
===========================================
- Coverage   55.74%   40.52%   -15.22%     
===========================================
  Files         150      150               
  Lines       14144    14217       +73     
===========================================
- Hits         7884     5761     -2123     
- Misses       6260     8456     +2196     
Flag Coverage Δ
jina 40.52% <0.00%> (-15.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/M area/testing This issue/PR affects testing labels Sep 19, 2024
@JoanFM JoanFM closed this Sep 19, 2024
@JoanFM JoanFM reopened this Sep 19, 2024
@JoanFM JoanFM merged commit 3894353 into master Sep 20, 2024
177 of 259 checks passed
@JoanFM JoanFM deleted the test-no-data-lock branch September 20, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/M size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant