fix(datastore): handle case when getting auth info for expired token …

…users (aws-amplify#13536) fix: handle case when getting auth info for expired token users Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com>
jjarvisp · Jul 1, 2024 · 0f5f4cb · 0f5f4cb
1 parent b6de5f9
commit 0f5f4cb
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/packages/datastore/__tests__/subscription.test.ts b/packages/datastore/__tests__/subscription.test.ts
@@ -126,6 +126,34 @@ describe('sync engine subscription module', () => {
 			),
 		).toEqual(authInfo);
 	});
+	test('owner authorization with no token(expired)', () => {
+		const authRules = [
+			{
+				provider: 'userPools',
+				ownerField: 'owner',
+				allow: 'owner',
+				identityClaim: 'cognito:username',
+				operations: ['create', 'update', 'delete'],
+			},
+		];
+		const model = generateModelWithAuth(authRules);
+
+		const authInfo = {
+			authMode: 'userPool',
+			isOwner: false,
+		};
+
+		expect(
+			// @ts-ignore
+			SubscriptionProcessor.prototype.getAuthorizationInfo(
+				model,
+				USER_CREDENTIALS.auth,
+				'userPool',
+				undefined,
+				'userPool',
+			),
+		).toEqual(authInfo);
+	});
 	test('owner authorization with public subscription', () => {
 		const authRules = [
 			{

diff --git a/packages/datastore/src/sync/processors/subscription.ts b/packages/datastore/src/sync/processors/subscription.ts
@@ -205,7 +205,7 @@ class SubscriptionProcessor {
 				: [];
 
 		oidcOwnerAuthRules.forEach(ownerAuthRule => {
-			const ownerValue = oidcTokenPayload[ownerAuthRule.identityClaim];
+			const ownerValue = oidcTokenPayload?.[ownerAuthRule.identityClaim];
 			const singleOwner =
 				model.fields[ownerAuthRule.ownerField]?.isArray !== true;
 			const isOwnerArgRequired =