fix: move urlsAreEqual to base class so all connections benefit

jkeen · Jan 11, 2024 · efd16a2 · efd16a2
1 parent f7d7435
commit efd16a2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/ember-stereo/src/stereo-connections/base.js b/ember-stereo/src/stereo-connections/base.js
@@ -538,6 +538,18 @@ export default class Sound extends Evented {
     assert('[ember-stereo] #stop interface not implemented', false);
   }
 
+  urlsAreEqual(url1, url2) {
+    // GOTCHA: audio.src is a fully qualified URL, and this.url may be a relative url
+    // So when comparing, make sure we're dealing in absolutes
+
+    let parser1 = document.createElement('a');
+    let parser2 = document.createElement('a');
+    parser1.href = url1;
+    parser2.href = url2;
+
+    return parser1.href === parser2.href;
+  }
+
   teardown() {
     // optionally implemented in subclasses
     this.isDestroyed = true;

diff --git a/ember-stereo/src/stereo-connections/native-audio.js b/ember-stereo/src/stereo-connections/native-audio.js
@@ -495,18 +495,6 @@ export default class NativeAudio extends BaseSound {
     }
   }
 
-  urlsAreEqual(url1, url2) {
-    // GOTCHA: audio.src is a fully qualified URL, and this.url may be a relative url
-    // So when comparing, make sure we're dealing in absolutes
-
-    let parser1 = document.createElement('a');
-    let parser2 = document.createElement('a');
-    parser1.href = url1;
-    parser2.href = url2;
-
-    return parser1.href === parser2.href;
-  }
-
   teardown() {
     let audio = this.requestControl();
     this.durationWorkaroundTask.cancelAll();