fix: Fire audio-ended event when fixed length audio ends using HLS co…

…nnection
jkeen · Sep 11, 2021 · f3d66b0 · f3d66b0
1 parent f768a04
commit f3d66b0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/addon/services/stereo.js b/addon/services/stereo.js
@@ -852,7 +852,7 @@ export default class Stereo extends Service.extend(EmberEvented) {
   }
 
   findSound(identifier) {
-    return this.soundProxy(identifier).value;
+    return this.soundProxy(identifier)?.value;
 
     //TODO: use a Proxy? it'd be neat to be able to 'find' a sound
     // that isn't loaded and attach events to it.

diff --git a/addon/stereo-connections/hls.js b/addon/stereo-connections/hls.js
@@ -143,6 +143,7 @@ export default class HLSSound extends BaseSound {
     });
 
     video.addEventListener('pause', () => this.trigger('audio-paused', { sound: this }));
+    video.addEventListener('ended', () => this.trigger('audio-ended', { sound: this }));
     video.addEventListener('durationchange', () => this.trigger('audio-duration-changed', { sound: this }));
     video.addEventListener('seeked', () => this.trigger('audio-position-changed', { sound: this, currentTime: this.currentTime }));
     video.addEventListener('timeupdate', () => this.trigger('audio-position-changed', { sound: this, currentTime: this.currentTime }));