Glitch filter unexpected callback #353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue occurs much more consistently when tests are run from a remote computer connecting to the Pi.
guymcswain
pushed a commit
that referenced
this pull request
Jun 26, 2020
The glitch filter was not cleared on GPIO and GPIO2, causing errors when rerunning tests.
guymcswain
pushed a commit
that referenced
this pull request
Jun 27, 2020
|
This patch was merged into v77. However, I left out the test since it used two gpio pins and both different from the current assumption that only GPIO 25 must be left unused. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is addresses issue #350 by waiting to initialize the glitch filter values until samples are first processed for the glitch filter. This helps to avoid problems with timing between the
SYST_CLOand sampleticks when settinggfTick.I also added a test case onto the wavechain and filter test section (but could make it a separate test too). The test usually fails when
x_pigpio.pyis run remotely, but rarely does when run locally. I added a command line argument tox_pigpio.pyto run with a remote Pi. All other tests pass with these changes.