FIX do not override Pickler's dispatch_table #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a Pickler instance already has methods in its dispatch table, do not override them. This bug showed up in cloudpipe/cloudpickle#253, where the Cloudpickler instances derives from the C Pickler, and most custom saving methods are inside dispatch_table, not dispatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
Picklerinstance already has methods in its dispatch table, do not override them. This bug showed up in cloudpipe/cloudpickle#253 and running this benchmark where theCloudpicklerinstances derives from the C_Picklerand most custom saving methods are insidedispatch_table, notdispatch.Given the current
set_loky_picklerstructure (private, nestedCustomizablePicklerclass), it is hard to write a proper test for it.