Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove externally-hosted diskdf corrections from the tests and docs #564

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

jobovy
Copy link
Owner

@jobovy jobovy commented Apr 19, 2023

GitHub finally seems to have stopped hosting the pre-calculated diskdf corrections that were available here:

https://github.com/downloads/jobovy/galpy/galpy-dfcorrections.tar.gz

so because these aren't crucial anyway, we remove any mention of them in the docs. They were also used in the tests (but, it turned out, weren't really necessary), so we remove them there as well. This did require re-saving the pre-calculated diskdf corrections that are included in the package as binary files, because apparently they weren't and this was not platform-independent.

…included pre-calculated corrections as binary; don't mentione downloadable corrections in the docs any more
@jobovy jobovy added this to the v1.9 milestone Apr 19, 2023
@jobovy jobovy self-assigned this Apr 19, 2023
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4ccd97a) 99.83% compared to head (8539390) 99.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         196      196           
  Lines       28598    28598           
=======================================
  Hits        28551    28551           
  Misses         47       47           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jobovy jobovy merged commit 861c2f7 into main Apr 19, 2023
@jobovy jobovy deleted the no-df-corrections branch April 19, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant