Skip to content

Commit

Permalink
fix: Fix tags in official Docker images and binaries
Browse files Browse the repository at this point in the history
The release workflows did not run checkout with fetch-tags: true, so
the builds were unable to compute the correct release version number.
I audited all instanced of actions/checkout to add fetch-tags where
needed and clean up unneeded options.

Closes shaka-project#1366
  • Loading branch information
joeyparrish committed Mar 12, 2024
1 parent 5ee2b7f commit 73a85ce
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ jobs:
with:
ref: ${{ inputs.ref }}
submodules: recursive
fetch-tags: true

- name: Install Linux deps
if: runner.os == 'Linux'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/publish-docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
with:
ref: ${{ inputs.tag }}
submodules: recursive
fetch-tags: true

- name: Log in to Docker Hub
uses: docker/login-action@v3
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release-please.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-tags: true
persist-credentials: false

- name: Compute latest
id: compute
Expand Down

0 comments on commit 73a85ce

Please sign in to comment.