Update generated smoke tests #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgetu
reviewed
Aug 1, 2024
| @@ -2156,8 +2122,8 @@ export class TestRunOperationsClient { | |||
| listMetricDefinitions(testRunId: string, metricNamespace: string, options?: ListMetricDefinitionsOptionalParams): Promise<TestRunOperationsClientMetricDefinitionCollection>; | |||
| listMetricDimensionValues(testRunId: string, name: string, metricname: string, metricNamespace: string, timespan: string, options?: ListMetricDimensionValuesOptionalParams): Promise<TestRunOperationsClientDimensionValueList>; | |||
| listMetricNamespaces(testRunId: string, options?: ListMetricNamespacesOptionalParams): Promise<TestRunOperationsClientMetricNamespaceCollection>; | |||
| listMetrics(testRunId: string, metricname: string, metricNamespace: string, timespan: string, body?: TestRunOperationsClientMetricRequestPayload, options?: ListMetricsOptionalParams): TestRunOperationsClientPagedAsyncIterableIterator<TestRunOperationsClientTimeSeriesElement>; | |||
| listTestRuns(options?: ListTestRunsOptionalParams): TestRunOperationsClientPagedAsyncIterableIterator<TestRunOperationsClientTestRun>; | |||
| listMetrics(testRunId: string, metricname: string, metricNamespace: string, timespan: string, body?: TestRunOperationsClientMetricRequestPayload, options?: ListMetricsOptionalParams): PagedAsyncIterableIterator<TestRunOperationsClientTimeSeriesElement>; | |||
MaryGao
reviewed
Aug 1, 2024
| @@ -1,20 +1,105 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
| // Licensed under the MIT license. | |||
|
|
|||
| // Copyright (c) Microsoft Corporation. | |||
| // Licensed under the MIT license. | |||
|
|
|||
MaryGao
reviewed
Aug 1, 2024
| } | ||
| } | ||
|
|
||
| export interface RestorePollerOptions< |
There was a problem hiding this comment.
why RestorePollerOptions here? it should be in restorePollerHelpers.ts.
MaryGao
reviewed
Aug 1, 2024
| } from "./models/index.js"; | ||
| export { | ||
| MultivariateOperations, | ||
| UnivariateOperations, | ||
| } from "./classic/index.js"; | ||
| export { PageSettings, ContinuablePage, PagedAsyncIterableIterator }; |
There was a problem hiding this comment.
nit: why not directly export like others?
MaryGao
reviewed
Aug 1, 2024
| @@ -687,7 +687,7 @@ export class TestProfileAdministrationOperationsClient { | |||
| createOrUpdateTestProfile(testProfileId: string, body: TestProfileAdministrationOperationsClientTestProfile, options?: CreateOrUpdateTestProfileOptionalParams): Promise<TestProfileAdministrationOperationsClientTestProfile>; | |||
| deleteTestProfile(testProfileId: string, options?: DeleteTestProfileOptionalParams): Promise<void>; | |||
| getTestProfile(testProfileId: string, options?: GetTestProfileOptionalParams): Promise<TestProfileAdministrationOperationsClientTestProfile>; | |||
| listTestProfiles(options?: ListTestProfilesOptionalParams): TestProfileAdministrationOperationsClientPagedAsyncIterableIterator<TestProfileAdministrationOperationsClientTestProfile>; | |||
| listTestProfiles(options?: ListTestProfilesOptionalParams): PagedAsyncIterableIterator<TestProfileAdministrationOperationsClientTestProfile>; | |||
There was a problem hiding this comment.
This is an example where the test case is only existing in smoke testing but not covered in UT or cadl-ranch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.