Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSpaceBeforeComma fixer add an unwanted space within numbers #28

Closed
graphidev opened this issue May 24, 2016 · 1 comment · Fixed by #29
Closed

NoSpaceBeforeComma fixer add an unwanted space within numbers #28

graphidev opened this issue May 24, 2016 · 1 comment · Fixed by #29

Comments

@graphidev
Copy link

Hi !

By using the french floating number notation (eg: 1,2), the NoSpaceBeforeComma fixer add an unwanted space after comma.

[...] « seule » 1,7 million de personnes [...]

is converted to :

[...] « seule » 1, 7 million de personnes [...]

This has been noticed using fr_FR locale and the following options :

'Ellipsis', 'Dimension', 'Numeric', 'Dash',  'SmartQuotes', 'FrenchNoBreakSpace', 'NoSpaceBeforeComma',  'CurlyQuote', 'Hyphen', 'Trademark'

But it seems not to be a conflict between fixers nor a locale trouble (tested both in my own project and using the demo page.)

@damienalexandre
Copy link
Member

Thanks for the great report! I found and fixed the issue in #29 👍

damienalexandre added a commit that referenced this issue May 25, 2016
Fix #28, the NoSpaceBeforeComma pattern was matching digits too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants