Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a support for PHAR building #64

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Add a support for PHAR building #64

merged 4 commits into from
Aug 31, 2021

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Aug 30, 2021

fix #54
fix #63
fix #62

@lyrixx lyrixx mentioned this pull request Aug 30, 2021
Closed
@lyrixx lyrixx force-pushed the phar branch 3 times, most recently from af804ee to 039246f Compare August 30, 2021 17:49
welcoMattic
welcoMattic approved these changes Aug 30, 2021
View reviewed changes
README.md Show resolved Hide resolved
tools/phar/README.md Outdated Show resolved Hide resolved
tools/phar/composer.json Outdated Show resolved Hide resolved
@welcoMattic
Copy link
Contributor

https://github.com/jolicode/JoliTypo/blob/039246f9e2b16c530bfc99056d8688561b2592f7/tools/phar/a.html should be removed, no?

@lyrixx lyrixx force-pushed the phar branch 2 times, most recently from 94d7ca1 to 6375741 Compare August 31, 2021 07:57
@lyrixx
Copy link
Member Author

lyrixx commented Aug 31, 2021 •
edited
Loading

@welcoMattic I addressed your comments 👍🏼

damienalexandre
damienalexandre approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@damienalexandre damienalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note in the Changelog could be added too.

I'm not a big fan of the hardcoded $recommendedRulesByLocale also. That should either be in the main library, or nowhere IMO.

@lyrixx
Copy link
Member Author

lyrixx commented Aug 31, 2021 •
edited
Loading

I'm not a big fan of the hardcoded $recommendedRulesByLocale also. That should either be in the main library, or nowhere IMO.

I moved it to the main lib

And I also added the phar compilation in the CI

@lyrixx lyrixx merged commit ed608d7 into master Aug 31, 2021
@lyrixx lyrixx deleted the phar branch August 31, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welcoMattic welcoMattic welcoMattic approved these changes

@damienalexandre damienalexandre damienalexandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Distribute a PHAR version of JoliTypo Release a standalone version (.phar) with external config file
3 participants
@lyrixx @welcoMattic @damienalexandre