Add tests to make sure syntax errors are not suppressed.

jonasbb · Jul 12, 2024 · 17dec11 · 17dec11
1 parent 97543d0
commit 17dec11
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/serde_with/tests/hashbrown_0_14.rs b/serde_with/tests/hashbrown_0_14.rs
@@ -322,6 +322,10 @@ fn test_map_skip_error_hashmap() {
           }
         }"#,
     );
+    check_error_deserialization::<S>(
+        r#"{"tag":"type", "values":{"0": 1,}}"#,
+        expect!["trailing comma at line 1 column 33"],
+    );
     is_equal(
         S {
             tag: "round-trip".into(),

diff --git a/serde_with/tests/indexmap_1.rs b/serde_with/tests/indexmap_1.rs
@@ -282,6 +282,10 @@ fn test_map_skip_error_indexmap() {
           }
         }"#,
     );
+    check_error_deserialization::<S>(
+        r#"{"tag":"type", "values":{"0": 1,}}"#,
+        expect!["trailing comma at line 1 column 33"],
+    );
     is_equal(
         S {
             tag: "round-trip".into(),

diff --git a/serde_with/tests/indexmap_2.rs b/serde_with/tests/indexmap_2.rs
@@ -282,6 +282,10 @@ fn test_map_skip_error_indexmap() {
           }
         }"#,
     );
+    check_error_deserialization::<S>(
+        r#"{"tag":"type", "values":{"0": 1,}}"#,
+        expect!["trailing comma at line 1 column 33"],
+    );
     is_equal(
         S {
             tag: "round-trip".into(),

diff --git a/serde_with/tests/serde_as/lib.rs b/serde_with/tests/serde_as/lib.rs
@@ -572,6 +572,10 @@ fn test_vec_skip_error() {
         },
         r#"{"tag":"type","values":[0, "str", 1, [10, 11], -2, {}, 300]}"#,
     );
+    check_error_deserialization::<S>(
+        r#"{"tag":"type", "values":[0, "str", 1, , 300]}"#,
+        expect!["expected value at line 1 column 39"],
+    );
     is_equal(
         S {
             tag: "round-trip".into(),
@@ -618,6 +622,10 @@ fn test_map_skip_error_btreemap() {
           }
         }"#,
     );
+    check_error_deserialization::<S>(
+        r#"{"tag":"type", "values":{"0": 1,}}"#,
+        expect!["trailing comma at line 1 column 33"],
+    );
     is_equal(
         S {
             tag: "round-trip".into(),
@@ -706,6 +714,10 @@ fn test_map_skip_error_hashmap() {
           }
         }"#,
     );
+    check_error_deserialization::<S>(
+        r#"{"tag":"type", "values":{"0": 1,}}"#,
+        expect!["trailing comma at line 1 column 33"],
+    );
     is_equal(
         S {
             tag: "round-trip".into(),