Skip to content

Commit

Permalink
Verify API status check changes (Azure#18176)
Browse files Browse the repository at this point in the history
Draft PR to verify common changes.
  • Loading branch information
praveenkuttappan authored and jongio committed Feb 9, 2021
1 parent 13555eb commit dfd6274
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 128 deletions.
4 changes: 3 additions & 1 deletion eng/pipelines/templates/jobs/archetype-sdk-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ jobs:
displayName: "Tag scheduled builds"
condition: and(eq(variables['Build.SourceBranchName'],'master'),eq(variables['Build.Reason'],'Schedule'))
- template: /eng/common/pipelines/templates/steps/daily-dev-build-variable.yml
parameters:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
- pwsh: |
$skipDevBuildNumber = "false"
# For .NET builds the only case we want to not have dev build numbers on our packages is when it is manually queued and
Expand Down Expand Up @@ -89,7 +91,7 @@ jobs:
artifactName: packages
path: $(Build.ArtifactStagingDirectory)

- template: /eng/pipelines/templates/steps/create-apireview.yml
- template: /eng/common/pipelines/templates/steps/create-apireview.yml
parameters:
Artifacts: ${{parameters.Artifacts}}

Expand Down
19 changes: 0 additions & 19 deletions eng/pipelines/templates/steps/create-apireview.yml

This file was deleted.

104 changes: 0 additions & 104 deletions eng/scripts/Create-APIReview.ps1

This file was deleted.

17 changes: 13 additions & 4 deletions eng/scripts/Language-Settings.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,15 @@ function Get-dotnet-PackageInfoFromRepo ($pkgPath, $serviceDirectory, $pkgName)
$projectData = New-Object -TypeName XML
$projectData.load($projectPath)
$pkgVersion = Select-XML -Xml $projectData -XPath '/Project/PropertyGroup/Version'
return [PackageProps]::new($pkgName, $pkgVersion, $pkgPath, $serviceDirectory)
$sdkType = "client"
if ($pkgName -match "\.ResourceManager\." -or $pkgName -match "\.Management\.")
{
$sdkType = "mgmt"
}
$pkgProp = [PackageProps]::new($pkgName, $pkgVersion, $pkgPath, $serviceDirectory)
$pkgProp.SdkType = $sdkType
$pkgProp.IsNewSdk = $pkgName.StartsWith("Azure")
return $pkgProp
}
else
{
Expand Down Expand Up @@ -202,13 +210,14 @@ function Update-dotnet-CIConfig($pkgs, $ciRepo, $locationInDocRepo, $monikerId=$
}

# function is used to auto generate API View
function Find-dotnet-Artifacts-For-Apireview($artifactDir, $packageName = "")
function Find-dotnet-Artifacts-For-Apireview($artifactDir, $packageName)
{
# Find all nupkg files in given artifact directory
$pkg = Get-dotnet-Package-Artifacts $artifactDir
$PackageArtifactPath = Join-Path $artifactDir $packageName
$pkg = Get-dotnet-Package-Artifacts $PackageArtifactPath
if (!$pkg)
{
Write-Host "Package is not available in artifact path $($artifactDir)"
Write-Host "Package is not available in artifact path $($PackageArtifactPath)"
return $null
}
$packages = @{ $pkg.Name = $pkg.FullName }
Expand Down

0 comments on commit dfd6274

Please sign in to comment.