Unique and expiring jobs (Enterprise Faktory) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files
|
jonhoo
requested changes
Jan 4, 2024
jonhoo
reviewed
Jan 7, 2024
| assert_eq!(msg, "Job not unique"); | ||
| } else { | ||
| panic!("Expected protocol error.") | ||
| } |
There was a problem hiding this comment.
Should we also check that both job1 and job2 were enqueued?
There was a problem hiding this comment.
Will be addressed in PR
jonhoo
approved these changes
Jan 7, 2024
There was a problem hiding this comment.
This looks good now, thank you!
One thing I'd recommend is to make use of the doc_cfg nightly feature specifically on docs.rs to highlight things that are only available with ent. You can see an example of how to do this in fantoccini below. We can do that in a separate PR though!
|
Released in 0.12.3 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting those features under the feature called "ent", because looks like it is already a common abbreviation/label for Enterprise Faktory.
Referencing the Faktory's wiki with regard to API.
Covering these Ent Faktory features:
Will be added as separate PRs:
This change is