Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ILoggerFactory instead of TextWriter #14

Closed
jonsagara opened this issue Dec 14, 2023 · 0 comments
Closed

Use ILoggerFactory instead of TextWriter #14

jonsagara opened this issue Dec 14, 2023 · 0 comments
Assignees
@jonsagara
Labels
enhancement New feature or request
Milestone
1.1.0

Comments

@jonsagara
Copy link
Owner

jonsagara commented Dec 14, 2023 •
edited
Loading

Follow StackExchange.Redis's precedent and take a depdency on Microsoft.Extensions.Logging.ILoggerFactory (in Microsoft.Extensions.Logging.Abstractions).

For a large swath of the population, this will dramatically simplify the ability to get logging messages from this library.

(AFAICT, the population is just me at this point.)
@jonsagara jonsagara self-assigned this Dec 14, 2023
@jonsagara jonsagara added the enhancement New feature or request label Dec 14, 2023
@jonsagara jonsagara added this to the 1.1.0 milestone Dec 14, 2023
jonsagara added a commit that referenced this issue Dec 14, 2023
@jonsagara
#14: Replace TextWriter with ILoggerFactory for logging to external l…
83b4ac1 
…ogs.
jonsagara added a commit that referenced this issue Dec 14, 2023
@jonsagara
Merge pull request #15 from jonsagara/feature/log
d56b0fc 
#14: Replace TextWriter with ILoggerFactory for logging to external l…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonsagara jonsagara

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@jonsagara