Skip to content

Commit

Permalink
feat: hide context menu when onRenderContextMenu return false
Browse files Browse the repository at this point in the history
  • Loading branch information
Xremn committed Jan 30, 2024
1 parent 93676eb commit 82376d4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 4 additions & 1 deletion src/lib/components/modes/JSONEditorRoot.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,10 @@
let handleRenderContextMenu: OnRenderContextMenuInternal
$: handleRenderContextMenu = (items: ContextMenuItem[]) => {
return onRenderContextMenu(items, { mode, modal: insideModal, selection }) ?? (readOnly ? false: items)
return (
onRenderContextMenu(items, { mode, modal: insideModal, selection }) ??
(readOnly ? false : items)
)
}
export function patch(operations: JSONPatchDocument): JSONPatchResult {
Expand Down
4 changes: 2 additions & 2 deletions src/lib/components/modes/tablemode/TableMode.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,7 @@
}
function handleContextMenu(event: Event) {
if (!onRenderContextMenu([]) || isEditingSelection(documentState.selection)) {
if (!onRenderContextMenu([]) || isEditingSelection(documentState.selection)) {
return
}
Expand Down Expand Up @@ -1028,7 +1028,7 @@
}
function handleContextMenuFromTableMenu(event: MouseEvent) {
if (!onRenderContextMenu([]) ) {
if (!onRenderContextMenu([])) {
return
}
Expand Down

0 comments on commit 82376d4

Please sign in to comment.