chore: simplify getMaxSeverity

josdejong · Mar 27, 2024 · 8a6a1de · 8a6a1de
1 parent 2c88d93
commit 8a6a1de
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/src/lib/components/controls/ValidationErrorsOverview.svelte b/src/lib/components/controls/ValidationErrorsOverview.svelte
@@ -28,16 +28,14 @@
     expanded = true
   }
 
-  function getMaxSeverity(errors: ValidationError[]): ValidationSeverity | null {
-    if (errors.some((e) => e.severity === ValidationSeverity.error)) {
-      return ValidationSeverity.error
-    } else if (errors.some((e) => e.severity === ValidationSeverity.warning)) {
-      return ValidationSeverity.warning
-    } else if (errors.some((e) => e.severity === ValidationSeverity.info)) {
-      return ValidationSeverity.info
-    }
+  function getMaxSeverity(errors: ValidationError[]): ValidationSeverity | undefined {
+    const severities = [
+      ValidationSeverity.error,
+      ValidationSeverity.warning,
+      ValidationSeverity.info
+    ]
 
-    return null
+    return severities.find(severity => errors.some((error) => error.severity === severity))
   }
 </script>