Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Svelte 4 #303

Merged
merged 29 commits into from
Aug 21, 2023
Merged

Upgrade to Svelte 4 #303

merged 29 commits into from
Aug 21, 2023

Conversation

josdejong
Copy link
Owner

Fix #296

  • Upgraded to Svelte 4 providing improved TypeScript types.
  • Dropped re-exporting types and utility functions from immutable-json-patch and svelte.
  • Dropped deprecated types FontAwesomeIcon (use IconDefinition instead), DropdownButtonItem, MenuButtonItem, MenuSeparatorItem, MenuSpaceItem, and typeguard isMenuSpaceItem.
  • The vanilla-package does not embed types of dependencies anymore and instead,
    imports the dependencies and use the types from there.

@josdejong
chore: update all packages, most notably svelte@4
a2229cf
@josdejong
chore: fix TypeScript and ESLint issues (WIP)
491b11a
@josdejong
chore: add a few TypeScript types (WIP)
257a19c
@josdejong
Merge branch 'main' into chore/svelte4
e0c2a53 
# Conflicts:
#	src/lib/components/modes/JSONEditorRoot.svelte
#	src/lib/components/modes/treemode/TreeMode.svelte
@josdejong
chore: fix linting issues
7b5204b
@josdejong
fix: a11y warnings
0a718f0
@josdejong
fix: linting issues
be06062
@josdejong
fix: update test snapshots
7f8ee55
@josdejong
fix: eslint issues
e3e0102
@josdejong
chore: update all dependencies
a9a8cc7
@josdejong
fix: linting warnings
2c2af61
@josdejong
fix: prettier-plugin-svelte not working
f9f8b7e
@josdejong
chore: replace dependency codemirror with the underlying codemirror…
2d286e7 
… packages
@josdejong
chore: fix linting issues
d23df59
@josdejong
Merge branch 'main' into chore/svelte4
9624e59
@josdejong
chore: update dependencies and devDependencies
8d3d867
@josdejong
fix: type issues
92e7981
@josdejong
chore: remove redundant script postprocessVanillaTypes.js (WIP)
8995084
@josdejong
chore: fix type bundle. Import dependencies that are used in the type…
c1653a9 
…s bundle
@josdejong
chore: assert the extracted dependencies when creating package.json
b9b6160
@josdejong
chore: run CI tests on node.js 20
21acfd6
@josdejong
feat: drop re-exporting utility functions from immutable-json-patch
c668d70
@josdejong
feat: remove redundant file index-vanilla.ts
fc6156e
@josdejong
feat: drop deprecated types and typeguards
66c1e4e
@josdejong
chore: remove redundant config
c0af69e
@josdejong
feat: drop exported types from immutable-json-patch
3f34592
@josdejong
feat: drop support for node.js 16
cec197f
@josdejong
fix: some tests using assert.throws failing on Node.js 20
4f55e9c
@josdejong
fix: unit test giving different result on Node.js 20
98a9095
@josdejong josdejong mentioned this pull request Aug 21, 2023
Closed
@josdejong josdejong merged commit 4d0451e into main Aug 21, 2023
4 checks passed
@josdejong josdejong deleted the chore/svelte4 branch August 21, 2023 16:29
@josdejong
Copy link
Owner Author

Published now in v0.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Svelte 4, fix accessibility and linting warnings
1 participant
@josdejong