Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few test cases #557

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Add a few test cases #557

merged 2 commits into from
Apr 18, 2024

Conversation

xxdavid
Copy link
Collaborator

@xxdavid xxdavid commented Sep 21, 2023

Discovered while testing Gradualizer on an Elixir repo.

Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Btw, maybe you should consider patching your editor. :-) A decent editor automatically adds a newline at end-of-file.

@xxdavid
Copy link
Collaborator Author

xxdavid commented Oct 4, 2023

Oh, thanks for noticing. Newlines added, editor configured (I though it was already like that but apparently not).

And thank you for the review. :)

@zuiderkwast zuiderkwast merged commit 050b074 into josefs:master Apr 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants