-
Notifications
You must be signed in to change notification settings - Fork 10
Bump chunk-manifest-webpack-plugin version #17
Conversation
To support webpack 3 in peer dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked the commits in chunk-manifest-webpack-plugin
and I guess this looks OK if ~1.1.2
is used.
Before publishing a new version of inline-chunk-manifest-html-webpack-plugin
I think I'd want to pass in explicitly to not inline with chunk-manifest-webpack-plugin, but that can be done in a separate PR.
package.json
Outdated
@@ -30,7 +30,7 @@ | |||
"prettier": "^1.1.0" | |||
}, | |||
"dependencies": { | |||
"chunk-manifest-webpack-plugin": "~1.0.0" | |||
"chunk-manifest-webpack-plugin": "~1.1.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well patch to 1.1.2 as there apparently was a regression bug in 1.1.1. See below:
soundcloud/chunk-manifest-webpack-plugin@1321345
So I'd suggest ~1.1.2
.
@chrisui, please have a look at this comment: |
@jouni-kantola Thanks! Just updated the version number. |
@jouni-kantola any chance this could be merged and published soon? Sorry to pester, just really excited to get webpack 3 setup at work! |
I don't want to updare until this PR soundcloud/chunk-manifest-webpack-plugin#51 is merged and a new version of Sorry for the delayed answer. I'm occupied with newborn twins 🍼 |
You guys could use |
Thank you for the help, @chrisui. I now took the time to fork chunk-manifest-webpack-plugin. I'm bumping the version number to 2.0.0, as I'm dropping webpack 1 support (I don't even know if I've ever tested in webpack 1). In favour of merging PR #18, I'm closing this one. I've now set webpack 2/3 as peer dependency. I just published 2.0.0 to npm. |
To support webpack 3 in peer dependencies. Would be great to get this merged and published asap as it is a blocker for upgrading to webpack 3.
Resolves #16
Kept the tilde range but a more typical semver caret range might be more appropriate in future.