Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

Bump chunk-manifest-webpack-plugin version #17

Closed
wants to merge 2 commits into from

Conversation

chrisui
Copy link

@chrisui chrisui commented Jul 26, 2017

To support webpack 3 in peer dependencies. Would be great to get this merged and published asap as it is a blocker for upgrading to webpack 3.

Resolves #16

Kept the tilde range but a more typical semver caret range might be more appropriate in future.

To support webpack 3 in peer dependencies
Copy link
Owner

@jouni-kantola jouni-kantola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the commits in chunk-manifest-webpack-plugin and I guess this looks OK if ~1.1.2 is used.

Before publishing a new version of inline-chunk-manifest-html-webpack-plugin I think I'd want to pass in explicitly to not inline with chunk-manifest-webpack-plugin, but that can be done in a separate PR.

package.json Outdated
@@ -30,7 +30,7 @@
"prettier": "^1.1.0"
},
"dependencies": {
"chunk-manifest-webpack-plugin": "~1.0.0"
"chunk-manifest-webpack-plugin": "~1.1.1"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well patch to 1.1.2 as there apparently was a regression bug in 1.1.1. See below:
soundcloud/chunk-manifest-webpack-plugin@1321345

So I'd suggest ~1.1.2.

@jouni-kantola
Copy link
Owner

@chrisui, please have a look at this comment:
#16 (comment)

@chrisui
Copy link
Author

chrisui commented Jul 27, 2017

@jouni-kantola Thanks! Just updated the version number.

@chrisui
Copy link
Author

chrisui commented Aug 2, 2017

@jouni-kantola any chance this could be merged and published soon? Sorry to pester, just really excited to get webpack 3 setup at work!

@jouni-kantola
Copy link
Owner

jouni-kantola commented Aug 11, 2017

I don't want to updare until this PR soundcloud/chunk-manifest-webpack-plugin#51 is merged and a new version of chunk-manifest-webpack-plugin is published.

Sorry for the delayed answer. I'm occupied with newborn twins 🍼

@chaffeqa
Copy link

You guys could use @codemotion/chunk-manifest-webpack-plugin in the interim

See soundcloud/chunk-manifest-webpack-plugin#47 (comment)

@jouni-kantola
Copy link
Owner

Thank you for the help, @chrisui. I now took the time to fork chunk-manifest-webpack-plugin. I'm bumping the version number to 2.0.0, as I'm dropping webpack 1 support (I don't even know if I've ever tested in webpack 1).

In favour of merging PR #18, I'm closing this one. I've now set webpack 2/3 as peer dependency.

I just published 2.0.0 to npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants