Warn about missing algorithms arg only when verify is True

Since no signature verification will occur, passing in `algorithms` does not make much sense.
jpadilla · Jul 4, 2017 · 9e63858 · 9e63858
1 parent 74399b1
commit 9e63858
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/jwt/api_jws.py b/jwt/api_jws.py
@@ -118,7 +118,7 @@ def encode(self, payload, key, algorithm='HS256', headers=None,
     def decode(self, jws, key='', verify=True, algorithms=None, options=None,
                **kwargs):
 
-        if not algorithms:
+        if verify and not algorithms:
             warnings.warn(
                 'It is strongly recommended that you pass in a ' +
                 'value for the "algorithms" argument when calling decode(). ' +

diff --git a/jwt/api_jwt.py b/jwt/api_jwt.py
@@ -59,7 +59,7 @@ def encode(self, payload, key, algorithm='HS256', headers=None,
     def decode(self, jwt, key='', verify=True, algorithms=None, options=None,
                **kwargs):
 
-        if not algorithms:
+        if verify and not algorithms:
             warnings.warn(
                 'It is strongly recommended that you pass in a ' +
                 'value for the "algorithms" argument when calling decode(). ' +