Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Support TypedDict #730

Closed
wants to merge 4 commits into from
Closed

refactor: Support TypedDict #730

wants to merge 4 commits into from

Conversation

kkirsche
Copy link
Contributor

@kkirsche kkirsche commented Feb 1, 2022

This merge request adds support for TypedDict for Options and certain returns to improve type hints. This relies on the typing-extensions module if below Python 3.8 or uses the standard library's implementation if it's available.

Accidentally based off of #729

@kkirsche
Copy link
Contributor Author

kkirsche commented Feb 1, 2022

Unclear what the failure on the 3.8 build actually is

@auvipy
Copy link
Collaborator

auvipy commented Feb 2, 2022

I re started all jobs

@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2015 José Padilla
Copyright (c) 2015-2022 José Padilla
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this probably needs rebase?

@github-actions github-actions bot added the stale Issues without activity for more than 60 days label May 16, 2022
@kkirsche kkirsche closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues without activity for more than 60 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants