wasm: drop wasm_opt flag, it trips TSan and benefits are unclear. (en…

…voyproxy#380) Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jplevyak · Feb 3, 2020 · 01166b3 · 01166b3
1 parent 3903397
commit 01166b3
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 18 deletions.
diff --git a/source/extensions/common/wasm/v8/v8.cc b/source/extensions/common/wasm/v8/v8.cc
@@ -14,22 +14,13 @@
 #include "v8-version.h"
 #include "wasm-api/wasm.hh"
 
-namespace v8 {
-namespace internal {
-extern bool FLAG_wasm_opt;
-} // namespace internal
-} // namespace v8
-
 namespace Envoy {
 namespace Extensions {
 namespace Common {
 namespace Wasm {
 namespace V8 {
 
 wasm::Engine* engine() {
-  // Enable Wasm optimizations.
-  v8::internal::FLAG_wasm_opt = true;
-
   static const auto engine = wasm::Engine::make();
   return engine.get();
 }

diff --git a/test/extensions/common/wasm/test_data/test_rust.wasm b/test/extensions/common/wasm/test_data/test_rust.wasm
diff --git a/test/tools/wee8_compile/wee8_compile.cc b/test/tools/wee8_compile/wee8_compile.cc
@@ -10,12 +10,6 @@
 #include "v8-version.h"
 #include "wasm-api/wasm.hh"
 
-namespace v8 {
-namespace internal {
-extern bool FLAG_wasm_opt;
-} // namespace internal
-} // namespace v8
-
 uint32_t parseVarint(const byte_t*& pos, const byte_t* end) {
   uint32_t n = 0;
   uint32_t shift = 0;
@@ -142,9 +136,6 @@ wasm::vec<byte_t> stripWasmModule(const wasm::vec<byte_t>& module) {
 }
 
 wasm::vec<byte_t> serializeWasmModule(const char* path, const wasm::vec<byte_t>& content) {
-  // Enable Wasm optimizations.
-  v8::internal::FLAG_wasm_opt = true;
-
   const auto engine = wasm::Engine::make();
   if (engine == nullptr) {
     std::cerr << "ERROR: Failed to start V8." << std::endl;