build: pass YAML_DEFINE_STATIC to the CInterop
#398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we would now build CYaml statically, we would fail to indicate to clang the library was meant to be used statically and not dynamically. This cleans up some linker warnings when building SPM.
lynchsft
pushed a commit
to lynchsft/Yams
that referenced
this pull request
Sep 20, 2024
Merge in EOM/yams from ensemble_auto_update_56C92FA7-E82A-4165-BF01-B383093BB869 to main * commit '4e63a791f5d61b1ee97ce8c0c41eefb32d3701aa': build: pass `YAML_DEFINE_STATIC` to the CInterop (jpsim#398) Add 5.8 as a supported Swift version in the podspec Use Swift 5.8.2 in BCR's presubmit Add empty changelog section Release 5.0.6 Update Bazel dependencies (jpsim#396) Allow decoding from a Node (jpsim#395)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we would now build CYaml statically, we would fail to indicate to clang the library was meant to be used statically and not dynamically. This cleans up some linker warnings when building SPM.