Import Bionic module that's part of the new Android overlay #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsim
approved these changes
Jul 5, 2024
|
Hold on, may be a way to scope this more tightly, will check and let you know. |
finagolfin
changed the title
|
Alright, updated to use the new Bionic module instead, ready for review. |
jpsim
added a commit
to futurejones/Yams
that referenced
this pull request
Jul 10, 2024
tejassharma96
added a commit
to tejassharma96/Yams
that referenced
this pull request
Jul 10, 2024
# By JP Simard (3) and others # Via GitHub * upstream/main: Require Swift 5.7 or later (jpsim#424) Add empty changelog section Release 5.1.3 add support for riscv64 (jpsim#419) Add support for Android (jpsim#421) GitHub Actions workflow fixes (jpsim#422) add os(visionOS) support (jpsim#418) Bazel: support rules_swift 2.x (jpsim#420) Bump rexml from 3.2.5 to 3.2.8 # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new overlay was recently added to trunk in swiftlang/swift#72161 and swiftlang/swift#72634, then to 6.0 in swiftlang/swift#74758. I've been building it with this patch on my daily Android CI since the trunk addition, finagolfin/swift-android-sdk#151, and natively on Android too.
@jpsim, an easy review.