-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build fail on Android, cast float to double - support React Native 0.72 #270
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
That's interesting! |
@jpudysz The version of react-native is |
Were you able to compile it with 0.72? 😮 If that's the only change to compile I will accept this PR |
@jpudysz When we initially created the app we're currently managing in-house, the version was 0.72, and there hasn't been any version change since then. I've confirmed that there won't be any issues with compilation as long as the requested changes are made. 🤓 |
Cool, thank you for the PR! |
@jpudysz I should be the one thanking you for the quick response and implementation! 😁 |
Will release it later this week with some other minor improvements! For now please keep your local changes 🙏 |
ok ! thanks :) |
Summary
Hello, thank you very much for creating such a great open-source project.
I installed version 2.9.1 to use react-native-unistyles. However, I encountered the following error while building the Android app.
So, I successfully built the project after modifying
react-native-unistyles/cxx/UnistylesImpl.cpp
as requested. I'm not sure why the implicit conversion fails, but there are no functional issues. I’m submitting this PR because other users might encounter the same problem.