Skip to content

Commit

Permalink
fixup! split up jquerys to avoid browserstack timeout
Browse files Browse the repository at this point in the history
  • Loading branch information
timmywil committed Jun 3, 2024
1 parent 47a5412 commit 0964ddd
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 9 deletions.
15 changes: 8 additions & 7 deletions .github/workflows/browserstack.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
NODE_VERSION: 20.x
name: ${{ matrix.BROWSER }}
concurrency:
group: ${{ github.sha }}-${{ matrix.BROWSER }}
timeout-minutes: 90
group: ${{ github.sha }}-${{ matrix.BROWSER }}-${{ matrix.JQUERYS.name }}
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
Expand All @@ -34,6 +34,11 @@ jobs:
- 'Opera_latest-1'
- 'Safari_latest'
- 'Safari_latest-1'
JQUERYS:
- versions: '--jquery 3.x-git --jquery git --jquery 3.7.1 --jquery 3.6.4 --jquery 3.5.1 --jquery 3.4.1 --jquery 3.3.1 --jquery 3.2.1 --jquery 3.1.1 --jquery 3.0.0'
name: 'jQuery 3.x'
- versions: '--jquery 2.2.4 --jquery 1.12.4 --jquery 2.1.4 --jquery 1.11.3 --jquery 2.0.3 --jquery 1.10.2 --jquery 1.9.1 --jquery 1.8.3'
name: 'jQuery 1.x/2.x'

steps:
- name: Checkout
Expand Down Expand Up @@ -62,10 +67,6 @@ jobs:
run: |
npm run test:unit -- -v \
--browserstack "${{ matrix.BROWSER }}" \
--jquery 3.x-git --jquery git \
--jquery 3.7.1 --jquery 3.6.4 --jquery 3.5.1 --jquery 3.4.1 \
--jquery 3.3.1 --jquery 3.2.1 --jquery 3.1.1 --jquery 3.0.0 \
--jquery 2.2.4 --jquery 1.12.4 --jquery 2.1.4 --jquery 1.11.3 \
--jquery 2.0.3 --jquery 1.10.2 --jquery 1.9.1 --jquery 1.8.3 \
${{ matrix.JQUERYS.versions }} \
--run-id ${{ github.run_id }} \
--retries 3 --hard-retries 1
2 changes: 1 addition & 1 deletion tests/runner/browsers.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export async function createBrowserWorker( url, browser, options, restarts = 0 )
worker = await createWorker( {
...browser,
url: encodeURI( url ),
project: "jquery",
project: "jquery-ui",
build: `Run ${ runId }`,

// This is the maximum timeout allowed
Expand Down
2 changes: 1 addition & 1 deletion tests/runner/run.js
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ export async function run( {

for ( const browser of browsers ) {
for ( const suite of suites ) {
queueRuns( [ suite ], browser );
queueRuns( suite, browser );
}
}

Expand Down

0 comments on commit 0964ddd

Please sign in to comment.