Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect: Remove demos & visual tests of the transfer effect #2291

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mgol
Copy link
Member

@mgol mgol commented Sep 9, 2024

The transfer effect is deprecated and not present unless $.uiBackCompat is set to true. In previous UI versions, the default was including the backwards compat layer so these demos & tests worked; now they do not by default. Just remove them.

Fixes gh-2278

The transfer effect is deprecated and not present unless `$.uiBackCompat` is set
to `true`. In previous UI versions, the default was including the backwards
compat layer so these demos & tests worked; now they do not by default. Just
remove them.

Fixes jquerygh-2278
@mgol mgol added this to the 1.14.1 milestone Sep 9, 2024
@mgol mgol requested a review from fnagel September 9, 2024 22:17
@mgol mgol self-assigned this Sep 9, 2024
Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

@mgol mgol removed the Needs review label Sep 16, 2024
@mgol mgol merged commit 36ed9fc into jquery:main Sep 16, 2024
9 checks passed
@mgol mgol deleted the no-transfer-effect branch September 16, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1.14 needs $.uiBackCompat = true; to use transfer Effect
3 participants